Minimize stack space required to plan deeply nested binary expressions#4787
Merged
alamb merged 5 commits intoapache:masterfrom Jan 2, 2023
Merged
Minimize stack space required to plan deeply nested binary expressions#4787alamb merged 5 commits intoapache:masterfrom
alamb merged 5 commits intoapache:masterfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Re #4065 from @andygrove
Rationale for this change
This is a follow on to #4779 which reduced the stack space needed to plan in debug builds. This PR minimizes the stack required as much as I know how.
What changes are included in this PR?
Special case BinaryOp (see comments for explination)
Are these changes tested?
Yes (existing + new tests)
Are there any user-facing changes?
No